Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove outdated oas language, testbed cleanup 🧹 #796

Merged
merged 5 commits into from
Apr 4, 2023
Merged

chore: remove outdated oas language, testbed cleanup 🧹 #796

merged 5 commits into from
Apr 4, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Apr 4, 2023 •
edited
Loading

🧰 Changes

Writing some tests as part of #788 and ended up going down a bit of a rabbit hole 🕳️

  • Removes outdated guidance on recommending the oas CLI
  • Moves every usage of toThrow to toStrictEqual where possible (the latter is a stricter assertion)
  • Returns expect statements instead of await-ing them where possible
  • Removed some weird table-layout workaround logic in __tests__/index.test.ts since this was fixed in the most recent major version bump of command-line-usage.

🧬 QA & Testing

Do tests still pass?

@kanadgupta kanadgupta changed the title chore: remove outdated oas language, testbed cleanup chore: remove outdated oas language, testbed cleanup 🧹 Apr 4, 2023
@kanadgupta kanadgupta added refactor Issues about tackling technical debt documentation Improvements or additions to documentation labels Apr 4, 2023
@kanadgupta kanadgupta marked this pull request as ready for review April 4, 2023 20:44
@kanadgupta kanadgupta requested a review from erunion April 4, 2023 20:44
@kanadgupta kanadgupta merged commit 007b7e0 into next Apr 4, 2023
@kanadgupta kanadgupta deleted the testbed-cleanups branch April 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion